Change in osmo-msc[master]: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jan 25 03:56:13 UTC 2020


Hello pespin, laforge, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-msc/+/16933

to look at the new patch set (#2).

Change subject: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270
......................................................................

libvlr: use generic osmo_tdef API for T3250, T3260, and T3270

These timers so far were implemented as a list of unsigned integers,
which has never been initialized to any reasonable defaults. Since
they are used as state timeouts in several FSMs, we might end up
staying in some state forever.

Let's migrate to generic osmo_tdef API and use default values from
table 11.2 of 3GPP TS 24.008. This way the user can introspect and
change their values from the VTY / configuration file.

Change-Id: Ia8cf98da0aea0e626c5ff088a833d7359c43847f
Related: OS#4368
---
M doc/manuals/vty/msc_vty_reference.xml
M include/osmocom/msc/msc_common.h
M include/osmocom/msc/vlr.h
M src/libmsc/msc_net_init.c
M src/libvlr/vlr.c
M tests/test_nodes.vty
6 files changed, 22 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/33/16933/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16933
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia8cf98da0aea0e626c5ff088a833d7359c43847f
Gerrit-Change-Number: 16933
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200125/17a8d02a/attachment.htm>


More information about the gerrit-log mailing list