This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17007 ) Change subject: gprs_bssgp_pcu: fix invalid use of non-static data member 'frame' ...................................................................... gprs_bssgp_pcu: fix invalid use of non-static data member 'frame' The 'gprs_llc' is defined as a pure C structure with C++ specific extensions (methods), so it's rather a class. Accessing its field 'frame' statically causes Clang to throw a compilation error: gprs_bssgp_pcu.cpp:111:29: error: invalid use of non-static data member 'frame' if (len > sizeof(gprs_llc::frame)) Let's avoid this and use LLC_MAX_LEN as the size limitation. God knows what to expect from such a mix of C++ and C... Change-Id: I7f84bd776cc780a45880f136107f6e0bc56241d1 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/17007/1 diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index f00fc94..080245a 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -108,7 +108,7 @@ data = (uint8_t *) TLVP_VAL(tp, BSSGP_IE_LLC_PDU); len = TLVP_LEN(tp, BSSGP_IE_LLC_PDU); - if (len > sizeof(gprs_llc::frame)) + if (len > sizeof(LLC_MAX_LEN)) { LOGP(DBSSGP, LOGL_NOTICE, "BSSGP TLLI=0x%08x Rx UL-UD IE_LLC_PDU too large\n", tlli); return bssgp_tx_status(BSSGP_CAUSE_COND_IE_ERR, NULL, msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7f84bd776cc780a45880f136107f6e0bc56241d1 Gerrit-Change-Number: 17007 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200124/bd563649/attachment.htm>