Change in osmo-pcu[master]: tests/rlcmac: Use osmo_hexdump to print buffers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jan 24 17:53:12 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16988 )

Change subject: tests/rlcmac: Use osmo_hexdump to print buffers
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/16988/2/tests/rlcmac/RLCMACTest.cpp 
File tests/rlcmac/RLCMACTest.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/16988/2/tests/rlcmac/RLCMACTest.cpp@114 
PS2, Line 114: vector1
This print looks redundant as we print another vector1 below. Can we drop it (probably, in the follow-up changes)?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16988
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I56c24f934824e4e52a91a7273aec384b2e15aa67
Gerrit-Change-Number: 16988
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 24 Jan 2020 17:53:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200124/dbaba892/attachment.htm>


More information about the gerrit-log mailing list