This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `imsi unknown cause` to set the reject cause ...................................................................... Patch Set 4: Code-Review-1 (6 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16808/4/src/hlr_vty.c File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16808/4/src/hlr_vty.c@49 PS4, Line 49: "roaming-not-allowed" }, No need to break the line. https://gerrit.osmocom.org/c/osmo-hlr/+/16808/4/src/hlr_vty.c@85 PS4, Line 85: get_value_string_or_null We should not get NULL if everything is correct I think. https://gerrit.osmocom.org/c/osmo-hlr/+/16808/4/src/hlr_vty.c@88 PS4, Line 88: imsi_cause_code Why not just g_hlr->imsi_unknown_cause != GMM_CAUSE_IMSI_UNKNOWN (it's the default). https://gerrit.osmocom.org/c/osmo-hlr/+/16808/4/src/hlr_vty.c@356 PS4, Line 356: imsi unknown cause You have to add help string for every singe word of the command. Otherwise help message would be broken. Feel free to replace three vectors "imsi unknown cause" by one "subscriber-reject-cause" (so we can also avoid repeating "imsi unknown cause imsi-unknown"): "subscriber-reject-cause (...)", "Define Location Updating Reject cause to be send in case the subscriber is not known\n" "Cause value 0xXX (IMSI unknown)\n" "Cause value 0xXX (Roaming not allowed)" https://gerrit.osmocom.org/c/osmo-hlr/+/16808/4/src/hlr_vty.c@357 PS4, Line 357: GSUP cause This is actually GSM 04.08 GMM cause if I understand correctly. https://gerrit.osmocom.org/c/osmo-hlr/+/16808/4/src/hlr_vty.c@365 PS4, Line 365: Cannot find cause value to %s%s This shall not happen because VTY would not accept any other values than 'imsi-unknown' and 'roaming-not-allowed'. You can just do OSMO_ASSERT() to avoid Coverity warnings. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jan 2020 23:57:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200123/7d461f27/attachment.htm>