This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 ) Change subject: gprs_gmm_fsm.c: Implement RAT change between 2g and 3g ...................................................................... Patch Set 11: (4 comments) https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/11/src/sgsn/gprs_gmm.c File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/11/src/sgsn/gprs_gmm.c@1232 PS11, Line 1232: if (MSG_IU_UE_CTX(msg) && ctx->ran_type != MM_CTX_T_UTRAN_Iu) Would be nice adding a comment here like: /* Detect MS switched to new a Radio Access technology */ https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/11/src/sgsn/gprs_gmm.c@1644 PS11, Line 1644: if (MSG_IU_UE_CTX(msg) && mmctx->ran_type != MM_CTX_T_UTRAN_Iu) I don't like having this logic repeated in two places (here and in gsm48_rx_gmm_att_req), so a function is welcome here. I am actually wondering whether it would make sense to do this kind of check in the caller of these functions and not on each message type rx() function. https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/11/src/sgsn/gprs_gmm.c@1649 PS11, Line 1649: osmo_fsm_inst_dispatch(mmctx->gmm_fsm, E_GMM_COMMON_PROC_INIT_REQ, NULL); Why is this line needed/added? comment welcome. https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/11/src/sgsn/gprs_gmm.c@1663 PS11, Line 1663: if (!mmctx->gb.llme) That can only happen if we are in RAT change, so it makes sense to move it in the above code block you are ading imho. BTW, in Iu->GERAN change don't you probably need to set it to NULL? I have this feeling this kind of stuff shouldn't be done here but in the FSM when receiving the E_GMM_RAT_CHANGE event. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3fc614da6ba137e871ee0fe86ca22b6a4a354dd2 Gerrit-Change-Number: 15487 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 22 Jan 2020 17:06:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200122/dfcf6a45/attachment.htm>