Change in pysim[master]: Fixed reading of MSISDN parameter

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

herlesupreeth gerrit-no-reply at lists.osmocom.org
Wed Jan 22 15:05:35 UTC 2020


herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16947 )

Change subject: Fixed reading of MSISDN parameter
......................................................................


Patch Set 6:

> Patch Set 6: Code-Review-1
> 
> (2 comments)

>From 3GPP TS 24.008, EF-MSISDN, following is my understanding

The total length of EF-MSISDN Record length is X+14 bytes, where the first X bytes are Alpha identifier, so the actual number (not supporting extension number, just 10 bytes Dialing number max) will be present in the last 14 bytes (includes BCD length, TON/NPI Capability/Configuration2 Record Identifier and Extension5 Record Identifier as well) of "res".

Hence,

x_bytes = (len(res)/2) - 14
# xbytes here is the length of alpha identifier in "res"

Since in "res" each element (e.g. res[0]) is 4 bits, the BCD length is present in "res" 
 between indexes (x_bytes * 2) and (x_bytes * 2) + 2

Similarly, TON/NPI is present in next byte after BCD length and so on so forth

Please correct me if I am wrong. 

P.S: I have verified the MSISDN programmed on the SIM represented in the same way as it was programmed


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie914ae83d787e3f1a90f9f305bffd45053b8c863
Gerrit-Change-Number: 16947
Gerrit-PatchSet: 6
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Jan 2020 15:05:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200122/27183bce/attachment.htm>


More information about the gerrit-log mailing list