Change in libosmo-abis[master]: add ipa ping/pong keepalive for OML/RSL links between bts and bsc

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 )

Change subject: add ipa ping/pong keepalive for OML/RSL links between bts and bsc
......................................................................


Patch Set 10: Code-Review-1

(7 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c 
File src/input/ipaccess.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c@74 
PS10, Line 74: 	struct osmo_fsm_inst** ka_fsm;
I don't see a point in using pointers to pointers here simply to have 3 shorter lines which fit anyway, so better remove it and use e1i_ts->driver.ipaccess.ka_fsm for everyone's mental sanity :)


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c@130 
PS10, Line 130: 	struct osmo_fsm_inst** ka_fsm;
Again avoid this. If you want, catch any of this in a pointer: 
ipaccess_line_ts(bfd, line)
&ipaccess_line_ts(bfd, line)->driver
&ipaccess_line_ts(bfd, line)->driver.ipaccess


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c@262 
PS10, Line 262: 			ka_fsm = &ipaccess_line_ts(newbfd, new_line)->driver.ipaccess.ka_fsm;
This chunk is mostly copied from the OML part above. Feels like it'd be clearer to have it in a static function.


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c@304 
PS10, Line 304: 	struct osmo_fsm_inst** ka_fsm = &ipaccess_line_ts(bfd, line)->driver.ipaccess.ka_fsm;
Same, avoid pointers to pointers for this kind of use.


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c@390 
PS10, Line 390: 		struct osmo_fsm_inst* ka_fsm = ipaccess_line_ts(bfd, line)->driver.ipaccess.ka_fsm;
I didn't know you could do this with static inline functions (as if it was a macro). Not sure if all compilers are going to like it.


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c@1045 
PS10, Line 1045: 		if (line->ipa_kap) {
I see this chunk of code again and again. I'm sure it can go into a function.


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c@1111 
PS10, Line 1111: 	if (line->ipa_kap) {
Same chunk of code again.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a
Gerrit-Change-Number: 14743
Gerrit-PatchSet: 10
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Assignee: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 22 Jan 2020 12:12:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200122/3b39a379/attachment.htm>