Change in pysim[master]: Support for MSISDN programming

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16946 )

Change subject: Support for MSISDN programming
......................................................................


Patch Set 4: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/pysim/+/16946/4/pySim-prog.py 
File pySim-prog.py:

https://gerrit.osmocom.org/c/pysim/+/16946/4/pySim-prog.py@170 
PS4, Line 170: parser.add_option
Please move it closer to ICCID/IMSI related options, this group and expand the help message (like other options do): "Mobile Subscriber Integrated Services Digital Number".


https://gerrit.osmocom.org/c/pysim/+/16946/4/pySim/cards.py 
File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/16946/4/pySim/cards.py@654 
PS4, Line 654: ton = "81"
             : 			if msisdn[0] == '+':
             : 				ton = "91"
Please clarify these values:

  ton = "XX" # e.g. Local number
  ton = "YY" # International number

Also, this is not just ToN but also NPI?


https://gerrit.osmocom.org/c/pysim/+/16946/4/pySim/cards.py@659 
PS4, Line 659: (l== -1)
this is always True, isn't it? Also, this variable looks unused.


https://gerrit.osmocom.org/c/pysim/+/16946/4/pySim/cards.py@666 
PS4, Line 666: MSISDN with even number of digits are supported
Can we just append symbol 'f' at the end of msisdn?



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16946
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie033a0ffc3697ae562eaa7a241a0f6af6c2b0594
Gerrit-Change-Number: 16946
Gerrit-PatchSet: 4
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 21 Jan 2020 23:14:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200121/ac658dbe/attachment.htm>