Change in osmo-sgsn[master]: WIP: implement ran change between 2g and 3g

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Jan 21 18:16:20 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 )

Change subject: WIP: implement ran change between 2g and 3g
......................................................................


Patch Set 9:

(2 comments)

> Patch Set 9:
> 
> This seems to be the fix for OS#3727 (crash when moving from 3g to 2g or vice versa. I rebased it to get rid of the merge conflict, but I don't know what else this patch is missing. To me it looks like it does what it's supposed to. Should it still be WIP?

I moved it to WIP because I didn't had yet the time working on it and to prevent notifications on it. Thanks for rebasing it! The TTCN testcase should succeed if it's done. The testcases are outcomment to not run while jenkins. (SGSN_Iu)

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_gmm.c 
File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_gmm.c@1105 
PS2, Line 1105: 	if (ctx->ran_type == new_ran)
> I'd prefer getting rid of this check here and doing it in the caller instead, I think it's easier to […]
i think it's better this way.


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_mm_state_gb_fsm.c 
File src/sgsn/gprs_mm_state_gb_fsm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_mm_state_gb_fsm.c@49 
PS2, Line 49: 	case E_MM_RAN_CHANGE:
> Are you sure this cannot happen in MM_STANDBY? Just a guess: I have the feeling you want to have it  […]
right. it should also happen MM_STANDBY



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15487
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3fc614da6ba137e871ee0fe86ca22b6a4a354dd2
Gerrit-Change-Number: 15487
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Jan 2020 18:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200121/755aa549/attachment.htm>


More information about the gerrit-log mailing list