This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16940 ) Change subject: Added feature to read Service Provider Name (SPN) from the SIM card ...................................................................... Patch Set 2: Code-Review-1 (1 comment) regarding the V-1 (verification of tests -1): If you change the output of the program, the test results will no longer match. You will need to modify the pysim-testdata/*.ok files to the exact expected new output (can be seen in the log file of the test executor, see https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/207/a1=default,a2=default,a3=default,a4=default,label=simtester/console) Hoewever, given the test executor outputs the following: PLMNwAcT: Can't read file -- SW match failed! Expected 9000 and got 9404. OPLMNwAcT: Can't read file -- SW match failed! Expected 9000 and got 9404. HPLMNAcT: Can't read file -- SW match failed! Expected 9000 and got 9404. I think there is something broken. It seems like it needs to be investigated what 9404 means, and the SW treated accordingly. https://gerrit.osmocom.org/c/pysim/+/16940/2/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/16940/2/pySim-read.py@133 PS2, Line 133: one more comment here: Please don't introduce new code that is only python 2.x, like this print without parentheisis. you can try to run your code explicitly with "python3 pySim-read.py" to verify before re-submitting. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/16940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8dc599a76c260ec2823ba5c9b22375b04a50daa8 Gerrit-Change-Number: 16940 Gerrit-PatchSet: 2 Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com> Gerrit-Assignee: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: dexter <pmaier at sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jan 2020 18:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200120/be25ff05/attachment.htm>