Change in pysim[master]: Initial implementation for programming MSISDN

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16946 )

Change subject: Initial implementation for programming MSISDN
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/16946/2/pySim-prog.py 
File pySim-prog.py:

https://gerrit.osmocom.org/c/pysim/+/16946/2/pySim-prog.py@279 
PS2, Line 279: if opts.name is not None and len(opts.name) > 16:
             : 		raise ValueError('Service Provider Name must max 16 characters!');
             : 		name = opts.name
             : 	else:
             : 		name = None
this seesm to belong to another change, as it's not MSISDN



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16946
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie033a0ffc3697ae562eaa7a241a0f6af6c2b0594
Gerrit-Change-Number: 16946
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 20 Jan 2020 14:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200120/5afde6d7/attachment.htm>