Change in osmo-msc[master]: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16933 )

Change subject: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-msc/+/16933/1/src/libvlr/vlr.c 
File src/libvlr/vlr.c:

https://gerrit.osmocom.org/c/osmo-msc/+/16933/1/src/libvlr/vlr.c@71 
PS1, Line 71: 	{ /* terminator */ }
> "I'll be back"
Absolutely!


https://gerrit.osmocom.org/c/osmo-msc/+/16933/1/src/libvlr/vlr.c@1268 
PS1, Line 1268: 	osmo_tdefs_reset(vlr->cfg.tdefs);
> That means afaiu each time a vlc is allocated, your VTY-set values will be erased. […]
That's how it's done in the other places of code. We never allocate more than one VLR anyway, so we can keep it as is for now. If somebody needs (for any not-obvious reason) more than one VLR, it can be changed to:

  vlr->cfg.tdefs = *vlr_instance_tdefs;
  osmo_tdefs_reset(&vlr->cfg.tdefs);

This is kind of a problem of the current osmo_tdef API - it mixes timer definition and current value in the same structure. I like the approach of osmo_fsm and osmo_fsm_inst.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16933
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia8cf98da0aea0e626c5ff088a833d7359c43847f
Gerrit-Change-Number: 16933
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Jan 2020 11:12:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200120/bce3d32c/attachment.htm>