Change in osmo-msc[master]: VTY: add osmo_tdef introspection and configuration commands

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jan 20 10:30:06 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16932 )

Change subject: VTY: add osmo_tdef introspection and configuration commands
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c 
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c@679 
PS1, Line 679: 	return osmo_tdef_vty_set_cmd(vty, tdefs, argv + 1);
argv[1]?


https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c@710 
PS1, Line 710: 	return osmo_tdef_vty_set_cmd(vty, tdefs, argv + 1);
argv[1] ?


https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c@844 
PS1, Line 844: 		osmo_tdef_vty_out_all(vty, list, "%*c", offset, ' '); \
Ugh, what does "%*c" mean?


https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c@848 
PS1, Line 848:       "show timer [all]",
AFAIu all here is not needed at all so it can be dropped? Or otherwise leave it as mandatory, but having it as optional is confusing, as the user thinks the behavior is different.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16932
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6024c104b6101666c8aa1108a043910eb75db9a5
Gerrit-Change-Number: 16932
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Jan 2020 10:30:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200120/70eb2391/attachment.htm>


More information about the gerrit-log mailing list