Change in ...osmo_gsup[master]: PDP_INFO_COMPLETE IE is optional for insert_sub_data_req

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jan 19 13:12:20 UTC 2020


Hello lynxis lazus,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16937

to review the following change.


Change subject: PDP_INFO_COMPLETE IE is optional for insert_sub_data_req
......................................................................

PDP_INFO_COMPLETE IE is optional for insert_sub_data_req

Change-Id: I37fdfc68ae47fe35ef010711be20995680260c2c
---
M include/gsup_protocol.hrl
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_gsup refs/changes/37/16937/1

diff --git a/include/gsup_protocol.hrl b/include/gsup_protocol.hrl
index a08b934..569def7 100644
--- a/include/gsup_protocol.hrl
+++ b/include/gsup_protocol.hrl
@@ -182,7 +182,7 @@
   16#0c => #{message_type => purge_ms_req, mandatory => [], optional => [cn_domain, hlr_number]},
   16#0d => #{message_type => purge_ms_err, mandatory => [cause]},
   16#0e => #{message_type => purge_ms_res, mandatory => [freeze_p_tmsi]},
-  16#10 => #{message_type => insert_sub_data_req, mandatory => [pdp_info_complete], optional => [cn_domain, msisdn, hlr_number, pdp_info_list, pdp_charging]},
+  16#10 => #{message_type => insert_sub_data_req, mandatory => [], optional => [cn_domain, msisdn, hlr_number, pdp_info_complete, pdp_info_list, pdp_charging]},
   16#11 => #{message_type => insert_sub_data_err, mandatory => [cause]},
   16#12 => #{message_type => insert_sub_data_res, mandatory => []},
   16#14 => #{message_type => delete_sub_data_req, mandatory => [], optional => [cn_domain, pdp_context_id]},

-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16937
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_gsup
Gerrit-Branch: master
Gerrit-Change-Id: I37fdfc68ae47fe35ef010711be20995680260c2c
Gerrit-Change-Number: 16937
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200119/c46c90f6/attachment.htm>


More information about the gerrit-log mailing list