Change in osmo-hlr[master]: osmo-mslookup-client.c: fix dereferencing null

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Jan 14 09:44:22 UTC 2020


osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16843 )

Change subject: osmo-mslookup-client.c: fix dereferencing null
......................................................................

osmo-mslookup-client.c: fix dereferencing null

Fixes: CID#207544
Change-Id: I51b974420975e670708f0d2318f63615d281922c
---
M src/mslookup/osmo-mslookup-client.c
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/mslookup/osmo-mslookup-client.c b/src/mslookup/osmo-mslookup-client.c
index 1c0efe9..5f06d5f 100644
--- a/src/mslookup/osmo-mslookup-client.c
+++ b/src/mslookup/osmo-mslookup-client.c
@@ -315,17 +315,18 @@
 	struct msgb *msg = osmo_mdns_result_encode(ctx, 0, &q, &r, cmdline_opts.mdns_domain_suffix);
 	if (!msg) {
 		print_error("unable to encode mDNS response\n");
-		goto exit_cleanup;
+		goto exit_cleanup_sock;
 	}
 
 	if (osmo_mdns_sock_send(sock, msg)) {
 		print_error("unable to send mDNS message\n");
-		goto exit_cleanup;
+		goto exit_cleanup_sock;
 	}
 
 	rc = 0;
-exit_cleanup:
+exit_cleanup_sock:
 	osmo_mdns_sock_cleanup(sock);
+exit_cleanup:
 	talloc_free(ctx);
 	return rc;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16843
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I51b974420975e670708f0d2318f63615d281922c
Gerrit-Change-Number: 16843
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200114/2d7f7b48/attachment.htm>


More information about the gerrit-log mailing list