This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16788 ) Change subject: hlr: respect the num_auth_vectors requested ...................................................................... hlr: respect the num_auth_vectors requested Previous the hlr always returned the maximum possible auth vectors (5) to the client. Even when only asked for a single auth vector. Change-Id: I20c2b648456bc7ba1fc1321a7d42852158a3523c --- M src/hlr.c 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/hlr.c b/src/hlr.c index c3737d5..38b9022 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -234,6 +234,7 @@ struct osmo_gsup_message gsup_out; struct msgb *msg_out; bool separation_bit = false; + int num_auth_vectors = OSMO_GSUP_MAX_NUM_AUTH_INFO; int rc; subscr_create_on_demand(gsup->imsi); @@ -245,9 +246,13 @@ if (gsup->current_rat_type == OSMO_RAT_EUTRAN_SGS) separation_bit = true; + if (gsup->num_auth_vectors > 0 && + gsup->num_auth_vectors <= OSMO_GSUP_MAX_NUM_AUTH_INFO) + num_auth_vectors = gsup->num_auth_vectors; + rc = db_get_auc(dbc, gsup->imsi, conn->auc_3g_ind, gsup_out.auth_vectors, - ARRAY_SIZE(gsup_out.auth_vectors), + num_auth_vectors, gsup->rand, gsup->auts, separation_bit); if (rc <= 0) { gsup_out.message_type = OSMO_GSUP_MSGT_SEND_AUTH_INFO_ERROR; -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I20c2b648456bc7ba1fc1321a7d42852158a3523c Gerrit-Change-Number: 16788 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200110/b46e82e0/attachment.htm>