Change in osmo-hlr[master]: vty: show subscriber: show lu d, h, m, s ago, not just seconds

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16262 )

Change subject: vty: show subscriber: show lu d,h,m,s ago, not just seconds
......................................................................


Patch Set 15:

(2 comments)

https://gerrit.osmocom.org/c/osmo-hlr/+/16262/14/src/hlr_vty_subscr.c 
File src/hlr_vty_subscr.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16262/14/src/hlr_vty_subscr.c@62 
PS14, Line 62: #define UNIT_AGO(UNITNAME, UNITVAL) \
> can't find anything, let me know if you can
core/timer.h:

/* convert absolute time (in seconds) to elapsed days/hours/minutes */
#define OSMO_SEC2MIN(sec) ((sec % (60 * 60)) / 60)
#define OSMO_SEC2HRS(sec) ((sec % (60 * 60 * 24)) / (60 * 60))
#define OSMO_SEC2DAY(sec) ((sec % (60 * 60 * 24 * 365)) / (60 * 60 * 24)) /* we ignore leap year for simplicity */


And I was thinking about rate_ctr_handler_fmt() but doesn't seem really reusable here,


https://gerrit.osmocom.org/c/osmo-hlr/+/16262/14/src/hlr_vty_subscr.c@67 
PS14, Line 67: 		UNIT_AGO("d", 60*60*24);
> I don't see any wrong indentation?
My bad, I didn't see the else block starting before the define.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16262
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I0fe34e0f065160ef959b2b7b4dd040f3f2985f43
Gerrit-Change-Number: 16262
Gerrit-PatchSet: 15
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jan 2020 18:31:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200109/5fedb8a9/attachment.htm>