Change in osmo-msc[master]: vlr.c: fix condition to check MSISDN presence

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Jan 6 17:24:21 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16743 )

Change subject: vlr.c: fix condition to check MSISDN presence
......................................................................

vlr.c: fix condition to check MSISDN presence

msisdn_enc is a buffer, its address is always != 0

Change-Id: Ib2294d2cd339c36df599d7d134f979a572ac308a
---
M src/libvlr/vlr.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index f644df8..b164fd8 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -784,7 +784,7 @@
 	unsigned idx;
 	int rc;
 
-	if (gsup_msg->msisdn_enc) {//FIXME: vlr_subscr_set_msisdn()?
+	if (gsup_msg->msisdn_enc_len) {//FIXME: vlr_subscr_set_msisdn()?
 		gsm48_decode_bcd_number2(vsub->msisdn, sizeof(vsub->msisdn),
 					 gsup_msg->msisdn_enc,
 					 gsup_msg->msisdn_enc_len, 0);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16743
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib2294d2cd339c36df599d7d134f979a572ac308a
Gerrit-Change-Number: 16743
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200106/db479bae/attachment.htm>


More information about the gerrit-log mailing list