Change in osmo-ttcn3-hacks[master]: MSC: fix SM-RP-OA (SMSC Address) expectations for MT SMS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jan 5 20:02:08 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16738 )


Change subject: MSC: fix SM-RP-OA (SMSC Address) expectations for MT SMS
......................................................................

MSC: fix SM-RP-OA (SMSC Address) expectations for MT SMS

The SMSC Address in template t_SmsPars has been changed since [1].
That change caused test case failures because OsmoMSC hard-codes
a different SMSC Address. Let's fix this.

[1] Ia60bdd2498034b6b849f874cf1eee272abef2b47

Change-Id: I3bdb6a74c8b02e4bf8dc88634e2380c924242b4b
---
M msc/BSC_ConnectionHandler.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/38/16738/1

diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index ccebba1..eae5e56 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -1660,8 +1660,9 @@
 	rp := {
 		msg_ref := '42'O,
 		/* We don't really need to have both SM-RP-DA/OA here, because only one IE
-		 * is included in MO/MT SMS, and in the most cases it's the SMSC address. */
-		smsc_addr := t_RP_Addr('76722337'H)
+		 * is included in MO/MT SMS, and in the most cases it's the SMSC address.
+		 * NOTE: this address is currently hard-coded by OsmoMSC. */
+		smsc_addr := t_RP_Addr('447785016005'H)
 	},
 	tid := 0,
 	dlci := '03'O,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16738
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3bdb6a74c8b02e4bf8dc88634e2380c924242b4b
Gerrit-Change-Number: 16738
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200105/23d78d7d/attachment.htm>


More information about the gerrit-log mailing list