Change in osmocom-bb[master]: mobile: Fix encoding of cause in gsm480_tx_release_compl()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jan 5 18:44:44 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14853 )

Change subject: mobile: Fix encoding of cause in gsm480_tx_release_compl()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/14853/1/src/host/layer23/src/mobile/gsm480_ss.c 
File src/host/layer23/src/mobile/gsm480_ss.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/14853/1/src/host/layer23/src/mobile/gsm480_ss.c@404 
PS1, Line 404: tlv[2] = 0x80 | cause;
             : 		tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER;
> An idea for another change: cause should actually go after location. Please see section 10.5.4. […]
https://gerrit.osmocom.org/c/osmocom-bb/+/14879



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14853
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5
Gerrit-Change-Number: 14853
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 05 Jan 2020 18:44:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200105/9b6f1fa9/attachment.htm>


More information about the gerrit-log mailing list