This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15888 ) Change subject: l1sap: add measurement related struct members ...................................................................... Patch Set 5: > Patch Set 5: > > ping? this has been pending for about a month now. There's still the very suspicious union in there... I tried to investigate what this union is about, I can't find any good reason why it has to be there. No code seems to access ta_offs_qbits. According to git you have added this union some time ago with change Ibb58113c2819fe2d6d23ecbcfb8b3fce4055025d. The idea behind this was to keep ABI compatibility. However, I have now removed the union and kept the struct member ta_offs_256bits. I would suggest to do the same with the unions in struct info_meas_ind_param and struct ph_data_param. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2c34b02d329f9df190c5035c396403ca0a4f9c42 Gerrit-Change-Number: 15888 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 02 Jan 2020 13:52:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200102/4cba5d7b/attachment.htm>