Change in osmo-ggsn[master]: add Linux network namespace support for TUN device

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Feb 26 08:45:03 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17253 )

Change subject: add Linux network namespace support for TUN device
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ggsn/+/17253/1/lib/netns.c 
File lib/netns.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/17253/1/lib/netns.c@53 
PS1, Line 53: 	sigfillset(&intmask);
no return checking, but then... should those ever fail?  one might also wrap them in OSMO_ASSERT() calls if proper error handling is too much?


https://gerrit.osmocom.org/c/osmo-ggsn/+/17253/1/lib/netns.c@78 
PS1, Line 78: 	setns(default_nsfd, CLONE_NEWNET);
I think at least here the setns() call should be skipped if the open fails.  Yes, we return 'rc' below, but I guess we should return early on failure.


https://gerrit.osmocom.org/c/osmo-ggsn/+/17253/1/lib/netns.c@96 
PS1, Line 96: 	sk = socket(domain, type, protocol);
same here with the socket...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17253
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Idd0ad8fa9c8e7ba0aeec1b52947598d4d297b620
Gerrit-Change-Number: 17253
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 26 Feb 2020 08:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200226/07ca7d51/attachment.htm>


More information about the gerrit-log mailing list