This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17245 ) Change subject: tests/rlcmac: also verify encoding of MS RA Capability ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/17245/1/src/gsm_rlcmac.cpp File src/gsm_rlcmac.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17245/1/src/gsm_rlcmac.cpp@5770 PS1, Line 5770: int encode_gsm_ra_cap(bitvec *vector, MS_Radio_Access_capability_t *data) That's not used at all by osmo-pcu itself, so move it to the test cpp file. https://gerrit.osmocom.org/c/osmo-pcu/+/17245/1/tests/rlcmac/RLCMACTest.cpp File tests/rlcmac/RLCMACTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17245/1/tests/rlcmac/RLCMACTest.cpp@246 PS1, Line 246: /* Make sure there's 1 value (currently fails due to failed decoding) */ is this true anymore? (failure happening). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic46d6e56768f516203d27d8e7a5adb77afdf32b7 Gerrit-Change-Number: 17245 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 24 Feb 2020 09:02:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200224/b9e19a75/attachment.htm>