Change in osmo-pcu[master]: gsm_rlcmac: improve dissection of Packet Resource Request message

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Feb 23 09:56:49 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17050 )

Change subject: gsm_rlcmac: improve dissection of Packet Resource Request message
......................................................................


Patch Set 3: Code-Review-1

I think we should not merge this change unless the problem I described in [1] is resolved. This is not a fault of this change, but a weakness of the CSN.1 codec. We should read the source code of Pycrate and check how it handles optional fields.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17050
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibb4cbd3f5865415fd547e95fc24ff31df1aed4c0
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 23 Feb 2020 09:56:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200223/23256ef3/attachment.htm>


More information about the gerrit-log mailing list