Change in osmo-ci[master]: ansible: gsm-tester: Use file module instead of manual mkdir

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Feb 21 20:09:12 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17201 )

Change subject: ansible: gsm-tester: Use file module instead of manual mkdir
......................................................................

ansible: gsm-tester: Use file module instead of manual mkdir

>From ansible: [WARNING]: Consider using the file module with state=directory rather than running 'mkdir'.

Change-Id: I2c541878033360a9d427d13b62c1cc075d5f92b7
---
M ansible/roles/gsm-tester/tasks/main.yml
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Verified



diff --git a/ansible/roles/gsm-tester/tasks/main.yml b/ansible/roles/gsm-tester/tasks/main.yml
index ecdd254..db2a16c 100644
--- a/ansible/roles/gsm-tester/tasks/main.yml
+++ b/ansible/roles/gsm-tester/tasks/main.yml
@@ -365,18 +365,22 @@
   tags:
     - osmo-gsm-tester-proc
 
+- name: Install osmo-gsm-tester script helpers to /usr/local/bin (PATH) (mkdir)
+  file: path=/usr/local/bin state=directory
+
 - name: Install osmo-gsm-tester script helpers to /usr/local/bin (PATH)
   shell: |
-      mkdir -p /usr/local/bin/ && \
       cp utils/bin/*.sh /usr/local/bin/
   args:
     chdir: /root/osmo-gsm-tester
   tags:
     - osmo-gsm-tester-proc
 
+- name: Install osmo-gsm-tester sudoers.d files to /etc/sudoers.d/ (PATH (mkdir)
+  file: path=/etc/sudoers.d/ state=directory
+
 - name: Install osmo-gsm-tester sudoers.d files to /etc/sudoers.d/ (PATH)
   shell: |
-      mkdir -p /etc/sudoers.d/ && \
       cp utils/sudoers.d/* /etc/sudoers.d/
   args:
     chdir: /root/osmo-gsm-tester

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/17201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2c541878033360a9d427d13b62c1cc075d5f92b7
Gerrit-Change-Number: 17201
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200221/f45831cf/attachment.htm>


More information about the gerrit-log mailing list