Change in osmo-gsm-tester[master]: iperf3: Fix netns param not used

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Feb 20 14:29:09 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17236 )

Change subject: iperf3: Fix netns param not used
......................................................................

iperf3: Fix netns param not used

Change-Id: I2768ec0c6d2cbfc8411382a983e1ba17cb5f097e
---
M src/osmo_gsm_tester/iperf3.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/iperf3.py b/src/osmo_gsm_tester/iperf3.py
index 2038daa..1b13ffe 100644
--- a/src/osmo_gsm_tester/iperf3.py
+++ b/src/osmo_gsm_tester/iperf3.py
@@ -160,11 +160,11 @@
         self.run_dir = util.Dir(self.suite_run.get_test_run_dir().new_dir(self.name()))
         self.log_file = self.run_dir.new_file(IPerf3Client.LOGFILE)
         if self.runs_locally():
-            return self.prepare_test_proc_locally()
+            return self.prepare_test_proc_locally(netns)
         else:
-            return self.prepare_test_proc_remotely()
+            return self.prepare_test_proc_remotely(netns)
 
-    def prepare_test_proc_remotely(self, netns=None):
+    def prepare_test_proc_remotely(self, netns):
         self.rem_host = remote.RemoteHost(self.run_dir, self._run_node.ssh_user(), self._run_node.ssh_addr())
 
         remote_prefix_dir = util.Dir(IPerf3Client.REMOTE_DIR)
@@ -182,7 +182,7 @@
             self.process = self.rem_host.RemoteProcess(self.name(), popen_args, env={})
         return self.process
 
-    def prepare_test_proc_locally(self, netns=None):
+    def prepare_test_proc_locally(self, netns):
         pcap_recorder.PcapRecorder(self.suite_run, self.run_dir.new_dir('pcap'), None,
                                    'host %s and port not 22' % self.server.addr(), netns)
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17236
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I2768ec0c6d2cbfc8411382a983e1ba17cb5f097e
Gerrit-Change-Number: 17236
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200220/fdf02cdf/attachment.htm>


More information about the gerrit-log mailing list