Change in libosmocore[master]: bitvec: cosmetic: init i only once in bitvec_[un]pack()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Feb 18 22:11:08 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17219 )


Change subject: bitvec: cosmetic: init i only once in bitvec_[un]pack()
......................................................................

bitvec: cosmetic: init i only once in bitvec_[un]pack()

Change-Id: I5606ca34a72d42a9b6aafed662b995f9fa77be09
---
M src/bitvec.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/19/17219/1

diff --git a/src/bitvec.c b/src/bitvec.c
index 5dd0275..d7f32fb 100644
--- a/src/bitvec.c
+++ b/src/bitvec.c
@@ -431,7 +431,7 @@
  *  \return number of bytes (= bits) copied */
 unsigned int bitvec_pack(const struct bitvec *bv, uint8_t *buffer)
 {
-	unsigned int i = 0;
+	unsigned int i;
 	for (i = 0; i < bv->data_len; i++)
 		buffer[i] = bv->data[i];
 
@@ -444,7 +444,7 @@
  *  \return number of bytes (= bits) copied */
 unsigned int bitvec_unpack(struct bitvec *bv, const uint8_t *buffer)
 {
-	unsigned int i = 0;
+	unsigned int i;
 	for (i = 0; i < bv->data_len; i++)
 		bv->data[i] = buffer[i];
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17219
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5606ca34a72d42a9b6aafed662b995f9fa77be09
Gerrit-Change-Number: 17219
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200218/094ce6e0/attachment.htm>


More information about the gerrit-log mailing list