Change in osmo-pcu[master]: csn1: fix csnStreamDecoder(): update bit_offset in CSN_EXIST{_LH}

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 17 21:58:43 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17196 )

Change subject: csn1: fix csnStreamDecoder(): update bit_offset in CSN_EXIST{_LH}
......................................................................

csn1: fix csnStreamDecoder(): update bit_offset in CSN_EXIST{_LH}

Found while doing differential analysis (comparison against the
original implementation from Wireshark).

Change-Id: Ibd0b7400d78f7873c2a8d45267332f511b5c6fbb
---
M src/csn1.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/csn1.c b/src/csn1.c
index 31b8e00..2f05327 100644
--- a/src/csn1.c
+++ b/src/csn1.c
@@ -950,6 +950,7 @@
         *pui8 = fExist;
         LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);
         pDescr++;
+        bit_offset++;
         remaining_bits_len -= 1;
 
         if (!fExist)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17196
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibd0b7400d78f7873c2a8d45267332f511b5c6fbb
Gerrit-Change-Number: 17196
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200217/fee047c8/attachment.htm>


More information about the gerrit-log mailing list