Change in osmo-ttcn3-hacks[master]: remsim: More comments in RemsimClient_Tests

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17189 )

Change subject: remsim: More comments in RemsimClient_Tests
......................................................................

remsim: More comments in RemsimClient_Tests

Change-Id: I02363eaaaae6d7b849cd2a1d2b07f1343d58c2f2
---
M remsim/RemsimClient_Tests.ttcn
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/remsim/RemsimClient_Tests.ttcn b/remsim/RemsimClient_Tests.ttcn
index d5520ab..7bee899 100644
--- a/remsim/RemsimClient_Tests.ttcn
+++ b/remsim/RemsimClient_Tests.ttcn
@@ -36,6 +36,7 @@
 /* ConnectClientReq from client to remsim-server */
 testcase TC_srv_connectClient() runs on client_test_CT {
 	f_init();
+	/* expect inbound connectClientReq */
 	as_connectClientReq();
 	setverdict(pass);
 	f_sleep(1.0);
@@ -44,6 +45,7 @@
 /* ConnectClientReq from client to remsim-server */
 testcase TC_srv_connectClient_reject() runs on client_test_CT {
 	f_init();
+	/* expect inbound connectClientReq */
 	as_connectClientReq(res := illegalClientId);
 	/* expect disconnect by client */
 	RSPRO_SRV[0].receive(t_ASP_IPA_EVT_UD(ASP_IPA_EVENT_DOWN));
@@ -55,9 +57,13 @@
 testcase TC_srv_connectClient_configClientBank() runs on client_test_CT {
 	var BankSlot bslot := { 1, 0 };
 	f_init();
+	/* expect inbound connectClientReq */
 	as_connectClientReq();
+	/* configure client to connect to [simulated] bankd */
 	f_rspro_config_client_bank(bslot, ts_IpPort(ts_IPv4(mp_bankd_ip), mp_bankd_port));
+	/* expect inbound connect on simulated bankd */
 	f_rspro_srv_exp_connect(1);
+	/* expect inbound connectClientReq on simulated bankd */
 	as_connectClientReq(i := 1);
 	setverdict(pass);
 	f_sleep(1.0);
@@ -67,11 +73,13 @@
 testcase TC_srv_reconnect() runs on client_test_CT {
 	var BankSlot bslot := { 1, 0 };
 	f_init();
+	/* expect inbound connectClientReq */
 	as_connectClientReq();
 
 	/* disconnect the client from server and expect re-establish + re-connect */
 	f_rspro_srv_fini(0);
 	f_rspro_srv_init(0, mp_server_ip, mp_server_port, g_srv_comp_id, exp_connect := true);
+	/* expect inbound connectClientReq */
 	as_connectClientReq(i := 0);
 
 	setverdict(pass);
@@ -82,14 +90,19 @@
 testcase TC_bank_reconnect() runs on client_test_CT {
 	var BankSlot bslot := { 1, 0 };
 	f_init();
+	/* expect inbound connectClientReq */
 	as_connectClientReq();
+	/* configure client to connect to [simulated] bankd */
 	f_rspro_config_client_bank(bslot, ts_IpPort(ts_IPv4(mp_bankd_ip), mp_bankd_port));
+	/* expect inbound connect on simulated bankd */
 	f_rspro_srv_exp_connect(1);
+	/* expect inbound connectClientReq on simulated bankd */
 	as_connectClientReq(i := 1);
 
 	/* disconnect the client from bankd and expect re-establish + re-connect */
 	f_rspro_srv_fini(1);
 	f_rspro_srv_init(1, mp_bankd_ip, mp_bankd_port, g_bankd_comp_id, exp_connect := true);
+	/* expect inbound connectClientReq on simulated bankd */
 	as_connectClientReq(i := 1);
 
 	setverdict(pass);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17189
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I02363eaaaae6d7b849cd2a1d2b07f1343d58c2f2
Gerrit-Change-Number: 17189
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200217/0280bf86/attachment.htm>