This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17194 ) Change subject: csn1: fix csnStreamDecoder(): do not subtract no_of_bits twice ...................................................................... csn1: fix csnStreamDecoder(): do not subtract no_of_bits twice Found while doing differential analysis (comparison against the original implementation from Wireshark). Change-Id: Id2a4f03035cd8354d3fba0ad37571453d3986d21 --- M src/csn1.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/94/17194/1 diff --git a/src/csn1.c b/src/csn1.c index eedad75..a766bd3 100644 --- a/src/csn1.c +++ b/src/csn1.c @@ -306,7 +306,6 @@ if (remaining_bits_len >= no_of_bits) { - remaining_bits_len -= no_of_bits; if (no_of_bits <= 8) { guint8 ui8 = get_masked_bits8(vector, readIndex, bit_offset, no_of_bits); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id2a4f03035cd8354d3fba0ad37571453d3986d21 Gerrit-Change-Number: 17194 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200217/a10e508e/attachment.htm>