Change in osmo-pcu[master]: gsm_rlcmac: improve dissection of Packet Resource Request message

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Feb 14 19:48:54 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17050 )

Change subject: gsm_rlcmac: improve dissection of Packet Resource Request message
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17050/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/17050/2//COMMIT_MSG@11 
PS2, Line 11: This commit breaks a unit test.
> so what do we do about this? Is the test wrong? Is it sane to simply adjust the expected test output […]
I did a quick investigation using Pycrate (https://osmocom.org/issues/4382#note-1). Decoding results look good, but the encoder generates a different vector that Pycrate fails to decode...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17050
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibb4cbd3f5865415fd547e95fc24ff31df1aed4c0
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 14 Feb 2020 19:48:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200214/241d6cd0/attachment.htm>


More information about the gerrit-log mailing list