Change in osmo-pcu[master]: tests/rlcmac: fix malformed test vector for Packet Polling Request

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Feb 11 10:27:41 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17121 )

Change subject: tests/rlcmac: fix malformed test vector for Packet Polling Request
......................................................................


Patch Set 1: Code-Review-1

I think it makes sense to leave the old malformed one (marking it as so in the comment) and add the new one. You can see the old one was useful to find the issue :)

You may need to move it to a new test though (one which simply tests it returns an error), since of course encoding7decoding is then gonna fail and is not correct.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17121
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I663edfdaac0c065e08ab7b6dc50d2f18e433433c
Gerrit-Change-Number: 17121
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Feb 2020 10:27:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200211/7bc5b0b8/attachment.htm>


More information about the gerrit-log mailing list