This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
herlesupreeth gerrit-no-reply at lists.osmocom.orgherlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16944 ) Change subject: Fixed MCC and MCC representation in the output of pySim-read ...................................................................... Patch Set 6: (2 comments) https://gerrit.osmocom.org/c/pysim/+/16944/6/pySim/utils.py File pySim/utils.py: https://gerrit.osmocom.org/c/pysim/+/16944/6/pySim/utils.py@225 PS6, Line 225: digit3 > This argument can be optional and set to 0x0f by default. i agree https://gerrit.osmocom.org/c/pysim/+/16944/6/pySim/utils.py@230 PS6, Line 230: if digit3 == 0xF: > This condition is redundant, feel free to remove it. […] i agree here as well. This way the number of if else condition will reduce. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/16944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie699c0a38d5ae90e4d6109e4574ce860e4044096 Gerrit-Change-Number: 16944 Gerrit-PatchSet: 6 Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com> Gerrit-Assignee: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 11 Feb 2020 07:32:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200211/8e7c25e6/attachment.htm>