Change in osmo-pcu[master]: encoding: assert return value of bitvec_set_u64()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Feb 10 11:40:56 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17106 )

Change subject: encoding: assert return value of bitvec_set_u64()
......................................................................

encoding: assert return value of bitvec_set_u64()

Change-Id: Ic0de3ae34f06e41aacacb917f5a0214623259bdc
Fixes: OS#182120
---
M src/encoding.cpp
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/encoding.cpp b/src/encoding.cpp
index 23b35bd..a4a14dd 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -162,7 +162,8 @@
 {
 	dest->cur_bit = *write_index;
 
-	bitvec_set_u64(dest, enc_ws(ws), 5, false);
+	int rc = bitvec_set_u64(dest, enc_ws(ws), 5, false);
+	OSMO_ASSERT(rc == 0);
 
 	*write_index += 5;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17106
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic0de3ae34f06e41aacacb917f5a0214623259bdc
Gerrit-Change-Number: 17106
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200210/e86618e0/attachment.htm>


More information about the gerrit-log mailing list