This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17086 ) Change subject: Check return code of rlcmac decode/encode functions ...................................................................... Patch Set 1: Code-Review+1 (7 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/src/pdch.cpp@250 PS1, Line 250: Tx Downlink https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/src/pdch.cpp@710 PS1, Line 710: control Uplink control https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/src/tbf.cpp@1283 PS1, Line 1283: Tx This is redundant, the message already contains Downlink. https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/src/tbf.cpp@1388 PS1, Line 1388: Tx same here https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/tests/rlcmac/RLCMACTest.cpp File tests/rlcmac/RLCMACTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/tests/rlcmac/RLCMACTest.cpp@208 PS1, Line 208: assert Why not OSMO_ASSERT()? https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/tests/rlcmac/RLCMACTest.ok File tests/rlcmac/RLCMACTest.ok: https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/tests/rlcmac/RLCMACTest.ok@66 PS1, Line 66: vector1 == vector2 : FALSE Just noticed this o_O. Is it expected? https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17086/1/tests/tbf/TbfTest.cpp@2563 PS1, Line 2563: assert Why not OSMO_ASSERT? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iabcb768bd714680aa768b35c786dea2015d1e451 Gerrit-Change-Number: 17086 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Wed, 05 Feb 2020 00:02:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200205/9b0fb614/attachment.htm>