Change in osmo-sgsn[master]: gprs_gmm_fsm.c: Implement RAT change between 2g and 3g

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 )

Change subject: gprs_gmm_fsm.c: Implement RAT change between 2g and 3g
......................................................................


Patch Set 13:

(3 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/11/src/sgsn/gprs_gmm.c 
File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/11/src/sgsn/gprs_gmm.c@1644 
PS11, Line 1644: 	if (MSG_IU_UE_CTX(msg) && mmctx->ran_type != MM_CTX_T_UTRAN_Iu)
> Thanks for the clarification. […]
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/13/src/sgsn/gprs_gmm.c 
File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/13/src/sgsn/gprs_gmm.c@1254 
PS13, Line 1254: 	if (mmctx_did_rat_change(ctx, msg)) {
> unneeded {}
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/11/src/sgsn/gprs_gmm_fsm.c 
File src/sgsn/gprs_gmm_fsm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/11/src/sgsn/gprs_gmm_fsm.c@165 
PS11, Line 165: 			gmm_fsm_state_chg(fi, ST_GMM_DEREGISTERED);
> It looks to me like we should just have a fall-through to the default: case in addition to setting t […]
Done?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15487
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3fc614da6ba137e871ee0fe86ca22b6a4a354dd2
Gerrit-Change-Number: 15487
Gerrit-PatchSet: 13
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 09:25:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200204/881458e3/attachment.htm>