This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/17080 ) Change subject: mm_state_gb_fsm: Handle implicit detach from mm_standby ...................................................................... Patch Set 1: I'm not quite sure I understand. Do you want me to explain more why this is needed or do you doubt that it is? While refactoring the other patch I looked through the Iu and Gb FSMs and saw that in the Iu FSM the implicit detach event will always go to state DETACHED while in Gb it will not. Also the Gb FSM state STANDBY already has an out_state_mask which includes ST_MM_IDLE, but st_mm_standby() never transitions to it. Finally, st_mm_idle_on_enter() will clean up the llme, which is what we want to do during a RAT change. So apart from the last all are more meta-reasons for me. Another issu with this patch: src/sgsn/sgsn_libgtp.c:668 has an OSMO_ASSERT() on Gb FSM state not being IDLE. Will something break here? This could happen if an MS RAT-changes from 2G to 3G and back to 2G, right? The TTCN3 tests pass without this patch, so I moved it at the end to get the rest merged for the moment. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/17080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I63d04a2dcdc17b4df6616c515641c435d919c787 Gerrit-Change-Number: 17080 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 04 Feb 2020 09:08:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200204/6378dabc/attachment.htm>