This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
tnt gerrit-no-reply at lists.osmocom.orgtnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774 ) Change subject: icE1usb fw: Internal API for configuring E1 rx/tx config register ...................................................................... Patch Set 3: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774/3/firmware/ice40-riscv/icE1usb/e1.c File firmware/ice40-riscv/icE1usb/e1.c: https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774/3/firmware/ice40-riscv/icE1usb/e1.c@277 PS3, Line 277: e1_regs->tx.csr = (e1_regs->tx.csr & ~TXCR_PERMITTED) | g_e1.tx.cr; No that's not correct, the overflow bit (read only) is the same as the overflow clear (write only) for instance so this would clear all overflow ... Should be : g_e1.tx.cr = (g_e1.tx.cr & ~TX_CRPERMITED) & (cr & TXCR_PERMITTED); e1_regs->tx.csr = g_e1.tx.cr; https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774/3/firmware/ice40-riscv/icE1usb/e1.c@288 PS3, Line 288: } Same as TX -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ib23f9b99f169ab18d730bcf67b97a7b6bf863e98 Gerrit-Change-Number: 21774 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-Comment-Date: Wed, 30 Dec 2020 12:55:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201230/f387ff42/attachment.htm>