This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21882 ) Change subject: gbproxy: Add config option to name an SGSN ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-sgsn/+/21882/1/src/gbproxy/gb_proxy.c File src/gbproxy/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/21882/1/src/gbproxy/gb_proxy.c@301 PS1, Line 301: LOG > isn't this a message printed for every user plane packet? Should this be info? ACK, changing to DEBUGP I also changed the other log statements https://gerrit.osmocom.org/c/osmo-sgsn/+/21882/1/src/gbproxy/gb_proxy_vty.c File src/gbproxy/gb_proxy_vty.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/21882/1/src/gbproxy/gb_proxy_vty.c@270 PS1, Line 270: if (sgsn->name) : talloc_free((void *)sgsn->name); : : sgsn->name = talloc_strdup(sgsn, name); > we do have a helper for that so you don't have to open code this: osmo_talloc_replace_string Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21882 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2a3410dd9bebb242957e13a63ed70e447204203c Gerrit-Change-Number: 21882 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 29 Dec 2020 16:52:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201229/8b793d97/attachment.htm>