Change in libosmocore[master]: utils: add osmo-ns-dummy

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Dec 27 20:01:03 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21701 )

Change subject: utils: add osmo-ns-dummy
......................................................................


Patch Set 15: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21701/14/utils/osmo-ns-dummy.c 
File utils/osmo-ns-dummy.c:

https://gerrit.osmocom.org/c/libosmocore/+/21701/14/utils/osmo-ns-dummy.c@221 
PS14, Line 221: 			       OSMO_VTY_PORT_PCU);
> is this one ok? Should I really add a port for a test utility?
you could just use a command line argument and not have a default port number?  "stealing" a port might have unexpected side effects.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21701
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I127c178426bc1a3da8de251740eda93853030d6d
Gerrit-Change-Number: 21701
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 27 Dec 2020 20:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201227/82d9d53f/attachment.htm>


More information about the gerrit-log mailing list