Change in libosmocore[master]: gprs_ns2: sns: add log message when size/config retries exhausted

[lynxis lazus]

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21823 )

Change subject: gprs_ns2: sns: add log message when size/config retries exhausted
......................................................................

gprs_ns2: sns: add log message when size/config retries exhausted

Change-Id: I5f7c04b364807418f5ba22132fc889b46d66aed0
---
M src/gb/gprs_ns2_sns.c
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 8747129..027d1da 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1313,16 +1313,20 @@
 	gss->N++;
 	switch (fi->T) {
 	case 1:
-		if (gss->N >= nsi->timeout[NS_TOUT_TSNS_SIZE_RETRIES])
+		if (gss->N >= nsi->timeout[NS_TOUT_TSNS_SIZE_RETRIES]) {
+			LOGPFSML(fi, LOGL_ERROR, "NSE %d: Size retries failed. Selecting next IP-SNS endpoint.\n", nse->nsei);
 			osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_SELECT_ENDPOINT, NULL);
-		else
+		} else {
 			osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_SIZE, nsi->timeout[NS_TOUT_TSNS_PROV], 1);
+		}
 		break;
 	case 2:
-		if (gss->N >= nsi->timeout[NS_TOUT_TSNS_CONFIG_RETRIES])
+		if (gss->N >= nsi->timeout[NS_TOUT_TSNS_CONFIG_RETRIES]) {
+			LOGPFSML(fi, LOGL_ERROR, "NSE %d: Config retries failed. Selecting next IP-SNS endpoint.\n", nse->nsei);
 			osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_SELECT_ENDPOINT, NULL);
-		else
+		} else {
 			osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_CONFIG_BSS, nsi->timeout[NS_TOUT_TSNS_PROV], 2);
+		}
 		break;
 	}
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21823
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5f7c04b364807418f5ba22132fc889b46d66aed0
Gerrit-Change-Number: 21823
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201223/c42e9c70/attachment.htm>