This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21660 ) Change subject: handover_test: send ho detection ...................................................................... handover_test: send ho detection So far we skipped the HO Detection message, because the FSM also accepts a handover when the Handover Complete arrives without a Detection. Rather model the real behavior. Also send the EST IND message and RTP-ready events from the ho detection. Change-Id: Ib676e74f23ef9cd1b55262117822b0e110013bdc --- M tests/handover/handover_test.c 1 file changed, 44 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index 0e603fa..69b25a1 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -605,7 +605,32 @@ abis_rsl_rcvmsg(msg); } -/* send handover complete */ +static void send_ho_detect(struct gsm_lchan *lchan) +{ + struct msgb *msg = msgb_alloc_headroom(256, 64, "RSL"); + struct abis_rsl_rll_hdr *rh; + uint8_t chan_nr = gsm_lchan2chan_nr(lchan); + + fprintf(stderr, "- Send HO DETECT for %s\n", gsm_lchan_name(lchan)); + + rh = (struct abis_rsl_rll_hdr *) msgb_put(msg, sizeof(*rh)); + rh->c.msg_discr = ABIS_RSL_MDISC_DED_CHAN; + rh->c.msg_type = RSL_MT_HANDO_DET; + rh->ie_chan = RSL_IE_CHAN_NR; + rh->chan_nr = chan_nr; + rh->ie_link_id = RSL_IE_LINK_IDENT; + rh->link_id = 0x00; + + msg->dst = lchan->ts->trx->bts->c0->rsl_link; + msg->l2h = (unsigned char *)rh; + + abis_rsl_rcvmsg(msg); + + send_est_ind(lchan); + osmo_fsm_inst_dispatch(lchan->fi, LCHAN_EV_RTP_READY, 0); + +} + static void send_ho_complete(struct gsm_lchan *lchan, bool success) { struct msgb *msg = msgb_alloc_headroom(256, 64, "RSL"); @@ -615,9 +640,6 @@ struct gsm48_hdr *gh; struct gsm48_ho_cpl *hc; - send_est_ind(lchan); - osmo_fsm_inst_dispatch(lchan->fi, LCHAN_EV_RTP_READY, 0); - if (success) fprintf(stderr, "- Send HO COMPLETE for %s\n", gsm_lchan_name(lchan)); else @@ -975,6 +997,22 @@ return CMD_SUCCESS; } +DEFUN(ho_detection, ho_detection_cmd, + "ho-detect", + "Send Handover Detection to the most recent HO target lchan\n") +{ + if (!got_chan_req) { + fprintf(stderr, "Cannot ack handover/assignment, because no chan request\n"); + exit(1); + } + if (!got_ho_req) { + fprintf(stderr, "Cannot ack handover/assignment, because no ho request\n"); + exit(1); + } + send_ho_detect(chan_req_lchan); + return CMD_SUCCESS; +} + DEFUN(ho_complete, ho_complete_cmd, "ho-complete", "Send Handover Complete for the most recent HO target lchan\n") @@ -1005,6 +1043,7 @@ _expect_chan_activ(to); _ack_chan_activ(to); _expect_ho_req(from); + send_ho_detect(to); send_ho_complete(to, true); lchan_release_ack(from); return CMD_SUCCESS; @@ -1088,6 +1127,7 @@ install_element(CONFIG_NODE, &expect_chan_cmd); install_element(CONFIG_NODE, &ack_chan_cmd); install_element(CONFIG_NODE, &expect_ho_req_cmd); + install_element(CONFIG_NODE, &ho_detection_cmd); install_element(CONFIG_NODE, &ho_complete_cmd); install_element(CONFIG_NODE, &expect_ho_cmd); install_element(CONFIG_NODE, &ho_failed_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib676e74f23ef9cd1b55262117822b0e110013bdc Gerrit-Change-Number: 21660 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201223/06ad172f/attachment.htm>