This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21829 ) Change subject: abis_om2000: keep OM2K FSMs around, don't terminate ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2310 PS1, Line 2310: trx->rbs2000.trx_fi = fi; > in an alloc() function (returning the allocated struct) I would expect this to be done by the caller […] My original idea was to do as much as possible inside the function, to avoid having to repeat the same pattern around the function call at multiple caller sites, where the chance is high to change only one of the callers and forget about others. I have to check if we actually do have multiple callers left in the latet iteration of the code. If not, I can go for your proposal. Otherwise, I'd rather rename the function like _alloc_and_link or so. https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2326 PS1, Line 2326: if (strcmp(osmo_fsm_inst_state_name(bts_fi), "DONE") && > better check against bts->fi->state == <enum> yes, but that would mean the enum must be declared here already, which would mean that the enum definition no longer is next to the FSM, which I really like about this current code. So I decided to go for the strcmp, after all it is a super infrequent operation. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia37cffff5c451e1d79a52ccae41ab5718b4661d4 Gerrit-Change-Number: 21829 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 22 Dec 2020 11:01:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201222/5d3245b7/attachment.htm>