This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21829 ) Change subject: abis_om2000: keep OM2K FSMs around, don't terminate ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2310 PS1, Line 2310: trx->rbs2000.trx_fi = fi; in an alloc() function (returning the allocated struct) I would expect this to be done by the caller. You can also drop the OSMO:ASSERT you introduce above. https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2326 PS1, Line 2326: if (strcmp(osmo_fsm_inst_state_name(bts_fi), "DONE") && better check against bts->fi->state == <enum> https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2340 PS1, Line 2340: if (strcmp(osmo_fsm_inst_state_name(bts_fi), "DONE") && same, check against enum. https://gerrit.osmocom.org/c/osmo-bsc/+/21829/1/src/osmo-bsc/abis_om2000.c@2630 PS1, Line 2630: bts->rbs2000.bts_fi = fi; Same, I'd expect this to be done by caller. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia37cffff5c451e1d79a52ccae41ab5718b4661d4 Gerrit-Change-Number: 21829 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 22 Dec 2020 10:35:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201222/9af4bcbe/attachment.htm>