This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/21821 ) Change subject: gprs_ns2: sns: correct log message when no nsvcs available ...................................................................... gprs_ns2: sns: correct log message when no nsvcs available The log message should only shown if a reselection will be triggered. Change-Id: I96b280a927aba6ac09ce88aedfcf469243c4dffe --- M src/gb/gprs_ns2_sns.c 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/21/21821/1 diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c index 9b5021a..2a1266c 100644 --- a/src/gb/gprs_ns2_sns.c +++ b/src/gb/gprs_ns2_sns.c @@ -250,7 +250,6 @@ gss->sns_nsvc = tmp; } } else { - LOGPFSML(fi, LOGL_ERROR, "NSE %d: no remaining NSVC, resetting SNS FSM\n", nse->nsei); gss->sns_nsvc = NULL; osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_NO_NSVC, NULL); } @@ -1337,8 +1336,12 @@ /* reset when receiving GPRS_SNS_EV_NO_NSVC */ switch (event) { case GPRS_SNS_EV_NO_NSVC: - if (!gss->reselection_running) - osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_SELECT_ENDPOINT, NULL); + /* ignore reselection running */ + if (gss->reselection_running) + break; + + LOGPFSML(fi, LOGL_ERROR, "NSE %d: no remaining NSVC, resetting SNS FSM\n", nse->nsei); + osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_SELECT_ENDPOINT, NULL); break; case GPRS_SNS_EV_SELECT_ENDPOINT: /* tear down previous state -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I96b280a927aba6ac09ce88aedfcf469243c4dffe Gerrit-Change-Number: 21821 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201221/a0158dc8/attachment.htm>