This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21487 ) Change subject: WIP: gprs_ns2: add new vty2 ...................................................................... Patch Set 15: (9 comments) After talking with Daniel about this change. We come to the conclusion to remove the sns group feature and use all UDP binds for IP-SNS at the beginning. If ip-SNS needs to limit the udp binds. The limit should be written into the NSE https://gerrit.osmocom.org/c/libosmocore/+/21487/4/include/osmocom/gprs/gprs_ns2.h File include/osmocom/gprs/gprs_ns2.h: https://gerrit.osmocom.org/c/libosmocore/+/21487/4/include/osmocom/gprs/gprs_ns2.h@a39 PS4, Line 39: NS2_DIALECT_SNS, > good idea. Done https://gerrit.osmocom.org/c/libosmocore/+/21487/15/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/21487/15/src/gb/gprs_ns2_sns.c@1555 PS15, Line 1555: "somegroup" > ? bind group related. removed. https://gerrit.osmocom.org/c/libosmocore/+/21487/1/src/gb/gprs_ns2_vty2.c File src/gb/gprs_ns2_vty2.c: https://gerrit.osmocom.org/c/libosmocore/+/21487/1/src/gb/gprs_ns2_vty2.c@136 PS1, Line 136: vty_out(vty, "Interface %s already used.\n", VTY_NEWLINE); > Just also noticed: "Interface %s already used.\n", VTY_NEWLINE […] Ack https://gerrit.osmocom.org/c/libosmocore/+/21487/1/src/gb/gprs_ns2_vty2.c@1020 PS1, Line 1020: install_lib_element(L_FR_NODE, &cfg_no_fr_link_cmd); > I'll change it to […] Done https://gerrit.osmocom.org/c/libosmocore/+/21487/4/src/gb/gprs_ns2_vty2.c File src/gb/gprs_ns2_vty2.c: https://gerrit.osmocom.org/c/libosmocore/+/21487/4/src/gb/gprs_ns2_vty2.c@488 PS4, Line 488: > You could have #defines and simply use them twice Done https://gerrit.osmocom.org/c/libosmocore/+/21487/15/src/gb/gprs_ns2_vty2.c File src/gb/gprs_ns2_vty2.c: https://gerrit.osmocom.org/c/libosmocore/+/21487/15/src/gb/gprs_ns2_vty2.c@467 PS15, Line 467: argv[0], argv[1], VTY_NEWLINE); > no newline? Ack https://gerrit.osmocom.org/c/libosmocore/+/21487/15/src/gb/gprs_ns2_vty2.c@497 PS15, Line 497: vty_out(vty, "no listen can be only used with UDP bind%s", > no newline? Ack https://gerrit.osmocom.org/c/libosmocore/+/21487/15/src/gb/gprs_ns2_vty2.c@618 PS15, Line 618: vty_out(vty, "fr can be only used with frame relay bind%s", > no newline? you have mcuh longer lines below Ack https://gerrit.osmocom.org/c/libosmocore/+/21487/15/src/gb/gprs_ns2_vty2.c@860 PS15, Line 860: > isn't this a bit redundant? If we can delete just by nsvci above, what purpose has the delete-by-net […] this can be removed. my idea was to use the same line to configure a nsvc also can be used to remove it again. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I163279cf57e84198dc8c53e1c109f5a9474670e9 Gerrit-Change-Number: 21487 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 21 Dec 2020 11:25:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201221/0e0b80f1/attachment.htm>