This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21752 ) Change subject: gprs_ns2: fr: setup the device to correct FR/LMI settings ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/21752/3/src/gb/gprs_ns2_fr.c File src/gb/gprs_ns2_fr.c: https://gerrit.osmocom.org/c/libosmocore/+/21752/3/src/gb/gprs_ns2_fr.c@439 PS3, Line 439: int set_ifupdown(const char *netif, bool up) > this looks quite generic, may be wroth having it somewhere else in libosmocore (socket.h or netif. […] can be static. let's keep it here until someone else want to use it. https://gerrit.osmocom.org/c/libosmocore/+/21752/3/src/gb/gprs_ns2_fr.c@449 PS3, Line 449: st > as we just saw some fall-out from other strncpy (instead of osmo_strlcpy), it might make sense to go […] Ack https://gerrit.osmocom.org/c/libosmocore/+/21752/3/src/gb/gprs_ns2_fr.c@459 PS3, Line 459: int setup_device(const char *netif) > static? Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I04786d2b864860b08c2e1afdb199470f4b80cc3b Gerrit-Change-Number: 21752 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sun, 20 Dec 2020 16:17:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201220/bd0bd37f/attachment.htm>