Change in osmo-bsc[master]: power_control: add new structures and default parameters

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Dec 19 16:59:18 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21786 )

Change subject: power_control: add new structures and default parameters
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review+1
> 
> why are they dynamically allocated? What's the advantage over making them a static member of the bts?

It was my initial plan to have these structures statically allocated as a part of 'struct gsm_bts', but in the VTY code we need to be able to go back from 'cfg-power-control' nodes to 'config-net-bts'. I could add a back-pointer, but talloc allows us to get pointer to the parent chunk without adding anything. But wait, maybe containerof() would do the trick?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21786
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7fb8ccb997490b40a061d09c241359aaabc37c4a
Gerrit-Change-Number: 21786
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 19 Dec 2020 16:59:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201219/19c697ec/attachment.htm>


More information about the gerrit-log mailing list