Change in libosmocore[master]: gsm_08_58: fix wrong field order in 'struct ipac_preproc_pc_thresh'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Dec 19 16:44:46 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21806 )

Change subject: gsm_08_58: fix wrong field order in 'struct ipac_preproc_pc_thresh'
......................................................................

gsm_08_58: fix wrong field order in 'struct ipac_preproc_pc_thresh'

Thanks to the CLI of nanoBTS, I noticed that upper and lower RxQual
thresholds are sent in wrong order.  Only the little-endian variant
needs to be fixed, the big-endian one looks good.

Change-Id: If6ab2377bae6742f871589b529a349498775552f
Related: SYS#4918
---
M include/osmocom/gsm/protocol/gsm_08_58.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h
index 0f7af92..046d358 100644
--- a/include/osmocom/gsm/protocol/gsm_08_58.h
+++ b/include/osmocom/gsm/protocol/gsm_08_58.h
@@ -787,8 +787,8 @@
 #if OSMO_IS_LITTLE_ENDIAN
 	uint8_t l_rxlev:6, reserved_l_rxlev:2;
 	uint8_t u_rxlev:6, reserved_u_rxlev:2;
-	uint8_t l_rxqual:3, reserved_l_rxqual:1,
-		u_rxqual:3, reserved_u_rxqual:1;
+	uint8_t u_rxqual:3, reserved_u_rxqual:1,
+		l_rxqual:3, reserved_l_rxqual:1;
 #elif OSMO_IS_BIG_ENDIAN
 	uint8_t reserved_l_rxlev:2, l_rxlev:6;
 	uint8_t reserved_u_rxlev:2, u_rxlev:6;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21806
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If6ab2377bae6742f871589b529a349498775552f
Gerrit-Change-Number: 21806
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201219/a57b29d7/attachment.htm>


More information about the gerrit-log mailing list