This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21799 ) Change subject: osmo_e1f: Fix inverted logic of E bits ...................................................................... osmo_e1f: Fix inverted logic of E bits A value of '1' means _no_ CRC4 error observed. We got that right in the receive side, but not in the transmit side so far Change-Id: I5ef9ef3b9781da2f53f54253d31cdbf81957ea67 --- M software/obsolete/osmo_e1f.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/software/obsolete/osmo_e1f.c b/software/obsolete/osmo_e1f.c index a4cadb2..2c3fcfb 100644 --- a/software/obsolete/osmo_e1f.c +++ b/software/obsolete/osmo_e1f.c @@ -233,7 +233,7 @@ case 13: case 15: ret = 0x40; - if (e1i->tx.crc4_error) + if (!e1i->tx.crc4_error) ret |= 0x80; break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21799 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I5ef9ef3b9781da2f53f54253d31cdbf81957ea67 Gerrit-Change-Number: 21799 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201219/76a711b3/attachment.htm>